Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Modifier keys customizable #2925

Merged
merged 6 commits into from
May 2, 2016
Merged

make Modifier keys customizable #2925

merged 6 commits into from
May 2, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented May 1, 2016

@VictorHagsand i made up this based on #2680.
No added code, just properties. It may be cool.

closes #2680

@VictorHagsand
Copy link
Contributor

Very cool, thank you!
Saves us a bunch of overrides : )

@asturur
Copy link
Member Author

asturur commented May 1, 2016

yes you have to override 5 functions to change all keys.

@VictorHagsand
Copy link
Contributor

Yupp, did that already before i made this suggestion here, thought that it might be useful for other people as a standard feature. I assume this will get merged later?

@asturur
Copy link
Member Author

asturur commented May 2, 2016

i have to be sure it works good. did not try yet.
On May 2, 2016 02:21, "VictorHagsand" notifications@github.com wrote:

Yupp, did that already before i made this suggestion here, thought that it
might be useful for other people as a standard feature. I assume this will
get merged later?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#2925 (comment)

@asturur asturur merged commit fab0c05 into fabricjs:master May 2, 2016
@asturur asturur deleted the modifierKey branch May 2, 2016 06:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to select modifyer key
2 participants