Remove duplicate code and fix justify style issue #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kangax ready to merge! |
asturur
changed the title
| this._renderChars(method, ctx, words[i], left + leftOffset, top, lineIndex); | ||
| leftOffset += ctx.measureText(words[i]).width + spaceWidth; | ||
| // stretch the line | ||
| var words = line.split(/\s+/), |
There was a problem hiding this comment.
Hm, don't we have a separate method for this now?
There was a problem hiding this comment.
if you mean splitting words, no i don t think so.
i can check.
anyway that code needs a review.
measuring width of words without calculating styles is very wrong and produce bad ( rare ) result.
There was a problem hiding this comment.
no we do not have any method for splitting line in words.
kangax
added a commit
that referenced
this pull request
Jul 31, 2015
Remove duplicate code and fix justify style issue
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of cleaning plus bugfix:
IText justified without style breakdown.
Fixes case in wich spaceWidth is infinite.
The justified spaces are not calculated right as of now, but I cannot fix this bug now.