Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goalies missing #9

Open
skanti opened this issue Aug 20, 2019 · 1 comment
Open

goalies missing #9

skanti opened this issue Aug 20, 2019 · 1 comment

Comments

@skanti
Copy link

skanti commented Aug 20, 2019

super work,
however I think in your datasets e.g. FIFA19 the goalkeepers are missing. Can you fix that please?
@kafagy
Copy link
Owner

kafagy commented Jan 28, 2020

@skanti, sorry for the late reply. I just noticed that they don't have any GKs in their main player list. I will add extra lines to parse all the GKs from a different URL and then merge them into the existing dataset. Thanks for letting me know about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skanti @kafagy