Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for semver and build date in replace_binary() #66

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

osodracnai
Copy link
Contributor

adding bail out for some incorrect upgrades k3s-io/k3s#7537

@osodracnai osodracnai self-assigned this Jun 19, 2023
@osodracnai osodracnai requested a review from brandond June 20, 2023 12:40
@osodracnai osodracnai marked this pull request as ready for review June 21, 2023 16:24
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on the error text, but looks good otherwise!

scripts/upgrade.sh Outdated Show resolved Hide resolved
scripts/upgrade.sh Outdated Show resolved Hide resolved
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
Copy link

@johnatasr johnatasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants