Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includeUnknown not working as expected #27

Open
Devmacs opened this issue Feb 15, 2020 · 0 comments
Open

includeUnknown not working as expected #27

Devmacs opened this issue Feb 15, 2020 · 0 comments

Comments

@Devmacs
Copy link
Contributor

Devmacs commented Feb 15, 2020

I didn't test what SymSpell would return in this case, but this output doesn't seem right to me :

spellchecker.checkSpelling('eradicate', {
    includeUnknown: true,
    maxEditDistance: 4,
    verbosity: 1,
    includeSelf: false
});
// lastResults.length === 1, lastResults[0] --> 'eradicate'

Shouldn't includeSelf: false with includeUnknown: true return no results in this case? 'eradicate' is in the dictionary, so it isn't an unknown. As per Wolf's comment in another issue :

With includeUnknown=true input terms not contained in the dictionary, and with no suggestions in the dictionary within the maximum edit distance will be still included in the output.

Or did I misunderstand his explanation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant