Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu.open() should have an option to align x and y to the top right of the menu. #709

Open
andrewfulton9 opened this issue Jun 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@andrewfulton9
Copy link
Contributor

Problem

I am trying to add a button to an extension that opens a menu. The button is on the far right side of the window, so the menu is automatically shifting to fit into the window. If I use the forceX option a portion of the menu will be out of the window and not viewable.

See the thread here for more context.

Proposed Solution

I propose adding a parameter to Menu.IOpenOptions to specify how the menu would relate to x and y. It could be something like align with the possible options "right" and "left". "left" would be default and it would align the top-left of the menu to x and y. "right" would align the top-right of the menu to x and y.

@fcollonval
Copy link
Member

Thanks for the suggestion @andrewfulton9

Minor comment on the proposed solution: although accessibility concepts are not well integrated in existing Lumino code. For new proposals like this one, we should consider it more thoughtfully. Therefore, I would suggest having a default matching the language direction rather than left if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants