-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a setting for only using a single tab for diffs #620
Comments
That is a nice idea. But a better approach instead of all or none would be to set a maximum number of diff tab to be kept opened using a queue. If the setting is 0, then the behavior would be the actual. And if it is one, it will be the one you propose. And if it is something else, it would probably make more sense like looking at all changes in a commit (especially as diffing big file can be quite slow) but keeping the number of opened tabs acceptable. |
In VSCode when you click on a file it shows the diff in a separate diff tab. If you click on another file it shows the diff in the same diff tab. A new diff tab is only opened if you double-click on a file (or if no diff tab is already open). I would love for |
@dhirschfeld As you said in the other issue, what you're describing is part of a more complex feature in vscode called preview mode. Implementation of our own preview mode would probably best be first tackled in core before we implement our own flavor of it here in the git extension. Some thoughts:
|
Agreed with what @telamonian said above. In the VSCode file browser, a single-click opens a file in the so-called "preview mode" tab, leading to a nice consistency between the regular file browser and the Git one. Since a single-click doesn't do the same in the JupyterLab file browser, I'd also vote that this is first handled in core and then we can aim to have consistency between the the regular and the Git file browser. |
I agree too with @telamonian.
It will actually be more work than that as some widgets are inserted from as deep as
So quite some work to achieve it... Therefore I would accept a simpler approach within the extension from now. |
Description
Currently every diff is opened in a new jupyter tab. I propose a setting that would enable behavior similar to github desktop where there is only one tab for diffs, and opening a new diff would change what diff is displayed but not create a new tab.
The text was updated successfully, but these errors were encountered: