-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron-28 fails to start jupyterlab-desktop #786
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
@PF4Public Where are you seeing this issue? Are you trying to build JupyterLab Desktop locally or are you running a version that you downloaded and installed as a release? Thanks! |
I'm building it locally. It builds, but does not start with electron-28. PS: Sorry, I should've mentioned that from the start. |
@PF4Public is there any particular reason you are trying to upgrade to electron 28? we are currently at electron 27. |
It is probably failing due to ESM module support added to electron 28. |
I'm trying to keep a single electron binary in the system and build every application I use against that, not using the shipped electron binaries. I haven't yet tested electron-29 as I expect many breakages. But 28 looks solid amongst others.
Sounds plausible, could it be fixed? As far as I understand, |
we will take a more detailed look at this, once we upgrade to a higher electron version. |
Same with electron-29 (just a FYI) |
Starting
jupyterlab-desktop
with electron-28 fails with the following error:This does not happen if starting with electron-27. I've hardcoded
isDevMode()
to always returnfalse
, which solved this issue for me.I could not find the exact braking change which might've occured between those electron/node versions, it could very well be something on my system. Would you be able to verify whether you can also reproduce this issue?
The text was updated successfully, but these errors were encountered: