Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include @jupyterlab/builder in this package #16

Open
fcollonval opened this issue Jul 5, 2024 · 2 comments
Open

Include @jupyterlab/builder in this package #16

fcollonval opened this issue Jul 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@fcollonval
Copy link
Member

We should bring @jupyterlab/builder within this package and make it generic.

For now the code lives there: https://github.com/jupyterlab/jupyterlab/tree/main/builder

@fcollonval fcollonval added the enhancement New feature or request label Jul 5, 2024
@jtpio
Copy link
Member

jtpio commented Jul 23, 2024

After the move, should the package still be named @jupyterlab/builder, or @jupyter/builder?

Since the Python package seems to be named jupyter_builder at the moment:

https://github.com/jupyterlab/jupyterlab-builder/blob/c04e4a2523df1ccbfc2d4bf9edb34cdd2bd25fb3/pyproject.toml#L9

Looks like @jupyterlab/builder may be preferable to avoid changing extensions that depend on it. Although there might be some ways to handle renames of npm packages without too much disruption.

@fcollonval
Copy link
Member Author

@cronan03 to test this, you need to

  1. Bring the Typescript files and the package.json
  2. Build the Javascript assets; normally it should create a lib folder when you execute jlpm run build
  3. You should check that the code is calling those Javascript assets in that Python function:

https://github.com/jupyterlab/jupyterlab-builder/blob/c04e4a2523df1ccbfc2d4bf9edb34cdd2bd25fb3/jupyter_builder/federated_extensions.py#L215

That implies defining properly the core_path to get the correct builder variable (it should point to the lib/build-labextension.js file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants