-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix releaser job #82
Fix releaser job #82
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 3
Lines ? 290
Branches ? 0
======================================
Hits ? 0
Misses ? 290
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @fcollonval!!
cc @blink1073 FYI the failure of the jupyter-releaser was due to the step installing the package in the job before executing the check-release action. |
Ah, understood, thanks for following up. |
This fixes the jupyter releaser job. Actually the culprit was the installation package step.
Configuration to include the
packages
files in sdist without the transient build files is a bit tricky. The final solution is to callclean:lib
afterbuild:prod
in the build python step.