Add changelog for 1.0.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This ended up unmerged and I've now:
Is it okay if we close this, and then go for merges on the newly opened? I'll open up a changelog PR soonish to get a release out! |
|
If i read the title "add changelog for 1.0.0", its a notable difference in my understanding on whats done compared to "call it 1.0", so i went for the title change - felt a bit stubborn doing that since you just recently changed the title Min. Title updates of PRs is something i generally think can help anyone overview things effectively with relative low intrusion, but still an intrusion. Did that feel okay with you @minrk? |
|
@consideRatio yes, absolutely! I just removed the text about pre-commit since i removed those commits, too. Your title is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.