Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky UI tests #7370

Closed
jtpio opened this issue May 14, 2024 · 11 comments · Fixed by jupyterlab/jupyterlab#16335 or jupyterlab/jupyterlab#16409
Closed

Flaky UI tests #7370

jtpio opened this issue May 14, 2024 · 11 comments · Fixed by jupyterlab/jupyterlab#16335 or jupyterlab/jupyterlab#16409
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented May 14, 2024

It looks like we still have some flakiness with the notebook toolbar sometimes missing the overflow button menu:

image

cc @brichet who looked into the notebook toolbar recently (as part of #7311) and may know if that might also be happening in JupyterLab.

Originally posted by @jtpio in #7361 (comment)

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label May 14, 2024
@jtpio jtpio added this to the 7.2.x milestone May 14, 2024
@JasonWeill JasonWeill removed the status:Needs Triage Applied to issues that need triage label May 14, 2024
@brichet
Copy link
Contributor

brichet commented May 14, 2024

Thanks @jtpio for the ping.

Wondering if this is only a matter of time for the button to be visible, and if we want to fix it (if it's inconvenient to use) or only fix the test (waiting for the button to be visible).
Did you notice the missing button outside the tests?

@jtpio
Copy link
Member Author

jtpio commented May 14, 2024

Did you notice the missing button outside the tests?

Usually not, so it might indeed just be an issue with the tests.

There is some logic to wait for the kernel status animations to be gone before taking the screenshot, which may not be enough:

// wait for the kernel status animations to be finished
await waitForKernelReady(notebook);

But maybe there could indeed also be a check to wait for that button to be visible, just to be sure.

@brichet
Copy link
Contributor

brichet commented May 15, 2024

I can take a look at the test and we'll see if it's enough.

@brichet
Copy link
Contributor

brichet commented May 15, 2024

Probably related to #6731, see #7371 for details.

@jtpio
Copy link
Member Author

jtpio commented May 17, 2024

Re-opening to keep track of updating to a new JupyterLab version, and check if it fixes the flakiness.

@jtpio jtpio reopened this May 17, 2024
@jtpio
Copy link
Member Author

jtpio commented May 24, 2024

From #7378 (which should include jupyterlab/jupyterlab#16335), it looks like this time it is the button to toggle the virtual scrollbar that is sometimes showing up:

Actual Expected
image image

@brichet
Copy link
Contributor

brichet commented May 31, 2024

it looks like this time it is the button to toggle the virtual scrollbar that is sometimes showing up

I think it is another computation issue with the toolbar, but I can't tell why it was not an issue before.
The debugger is inserted late in the toolbar (because it wait for the debugger to be ready in the kernel).
If it is inserted while the resizer is running (the resizer positions items in the toolbar or in the popup toolbar), the last item is not taken into account during the computation.

@brichet
Copy link
Contributor

brichet commented May 31, 2024

Opened jupyterlab/jupyterlab#16409, it fixes this issue locally, during tests and usage.
Too bad that we don't have yet an easy way to run all the tests on CI with this PR...

@brichet
Copy link
Contributor

brichet commented Jun 4, 2024

I hope there will not be other issues with the new change... 😄

@jtpio
Copy link
Member Author

jtpio commented Jun 4, 2024

Yes, thanks for looking into them!

I'll re-open to keep track of it, which should be fixed after the next JupyterLab update.

@jtpio
Copy link
Member Author

jtpio commented Jul 1, 2024

Closing as likely fixed by #7416.

We can re-open if the failure still happens in the future. Thanks!

@jtpio jtpio closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment