Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Bot please update playwright snapshots" doesn't work #6859

Closed
andrii-i opened this issue May 5, 2023 · 3 comments · Fixed by #6880
Closed

"Bot please update playwright snapshots" doesn't work #6859

andrii-i opened this issue May 5, 2023 · 3 comments · Fixed by #6880
Labels
maintenance
Milestone
7.0

Comments

@andrii-i
Copy link
Contributor

andrii-i commented May 5, 2023 •
edited
Loading

Describe the bug
"Bot please update playwright snapshots" doesn't work as seen in #6847

Ah looks like the bot might be broken, but not sure why: https://github.com/jupyter/notebook/actions/runs/4866690782/jobs/8678479167

Originally posted by @jtpio in #6847 (comment)

To Reproduce
Attempt to use "Bot please update playwright snapshots" in a PR

Expected behavior
"Bot please update playwright snapshots" works and updates snapshots
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label May 5, 2023
@andrii-i andrii-i changed the title "Bot please update playwright snapshots" doesn't work as seen in "Bot please update playwright snapshots" doesn't work May 5, 2023
@jtpio jtpio added this to the 7.0 milestone May 5, 2023
@jtpio
Copy link
Member

jtpio commented May 5, 2023

Thanks @andrii-i for opening this issue 👍

Agree it should be fixed to ease development of Notebook 7.

@jtpio jtpio added maintenance and removed status:Needs Triage Applied to issues that need triage labels May 5, 2023
@jtpio jtpio mentioned this issue May 17, 2023
Closed
@jtpio
Copy link
Member

jtpio commented May 18, 2023

Looks like this is the cause of the issue:

image

Maybe adding some logs could already help with the troubleshooting.

@jtpio jtpio mentioned this issue May 18, 2023
Merged
@jtpio
Copy link
Member

jtpio commented May 25, 2023

The bot should now be back in action:

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Fix playwright bot jtpio/notebook
2 participants
@jtpio @andrii-i