Notebook 7: meta-issue

[fcollonval]

Here are some issues reported targeting notebook 7:

• notebook toolbar buttons are disabled: Extension is disabled in Notebook 7 jupyterlab/jupyterlab-git#1284

[vidartf]

Just for reference: What needs to be done on the nbdime side here?

[fcollonval]

As notebook v7 is using the JupyterLab command defined there:

nbdime/packages/labextension/src/plugin.ts

Line 212 in 2f856da

commands.addCommand(CommandIDs.diffNotebookCheckpoint, {

The issue comes from the isEnabled logic and the addition of the widget to the shell:

nbdime/packages/labextension/src/plugin.ts

Line 225 in 2f856da

shell.add(widget);

As it will be a no-op in notebook v7: https://github.com/jupyter/notebook/blob/29d665dbac144d143d843168da9823cab6498b0a/packages/application/src/shell.ts#L318

There are ways to now if the extension is running within JupyterLab or Notebook:

• having optional token dependency specific to one or the other
• using the app.name (like in that extension e.g.)

Those could be used to tune the command behavior.

---

Related issue opened in notebook : jupyter/notebook#7134