Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min version support #287

Merged
merged 5 commits into from
May 19, 2023
Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented May 19, 2023

Drop support for Python 3.7 and bump min version support.
Also update example notebook to use new comm package.

Fixes failing test:

>           assert normalized_expected_outputs == normalized_actual_outputs
E           assert [] == [{'output_type': 'stream', 'name': 'stderr', 'text': "<IPY-INPUT>:1: DeprecationWarning: The `ipykernel.comm.Comm` class has been deprecated. Please use the `comm` module instead.For creating comms, use the function `from comm import create_comm`.\n  comm = Comm('this-comm-tests-a-missing-handler', data={'id': 'foo'})\n"}]
E             Right contains one more item: {'name': 'stderr', 'output_type': 'stream', 'text': "<IPY-INPUT>:1: DeprecationWarning: The `ipykernel.comm.Comm` clas...he function `from comm import create_comm`.\n  comm = Comm('this-comm-tests-a-missing-handler', data={'id': 'foo'})\n"}
E             Full diff:
E               [
E             +  ,
E             -  {'name': 'stderr',
E             -   'output_type': 'stream',
E             -   'text': '<IPY-INPUT>:1: DeprecationWarning: The `ipykernel.comm.Comm` class '
E             -           'has been deprecated. Please use the `comm` module instead.For '
E             -           'creating comms, use the function `from comm import create_comm`.\n'
E             -           "  comm = Comm('this-comm-tests-a-missing-handler', data={'id': "
E             -           "'foo'})\n"},
E               ]

nbclient/tests/test_client.py:289: AssertionError

@blink1073 blink1073 enabled auto-merge (squash) May 19, 2023 11:48
@blink1073 blink1073 changed the title Update example notebook Bump min version support May 19, 2023
@blink1073 blink1073 merged commit cb7b4f7 into jupyter:main May 19, 2023
@blink1073 blink1073 deleted the fix-failing-test branch May 19, 2023 12:46
@blink1073
Copy link
Contributor Author

I'll release a minor version on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant