avoid duplicate 'Exception: message' in CellExecutionError #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracebacks end with this info, so no need to repeat it in our template Removes unused `__unicode__` method for Python 2 unicode reprs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracebacks end with this info, so no need to repeat it in our template unless the traceback is empty. Currently exceptions end with:
where the first
Exception: messageoccurs in the traceback, while the second is added by the message template. This PR removes the second, instead switching on an empty template inCellExecutionError.__str__.Removes unused
__unicode__method for Python 2 unicode reprs.