Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #182

Merged
merged 1 commit into from
Dec 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ If you were using these versions for the couple days they were up, move to 0.5.0
### Fixes

- Fix `OSError: [WinError 6] The handle is invalid` for windows/python<3.7 [#77](https://github.com/jupyter/nbclient/pull/77)
- Async wapper Exceptions no longer loose thier caused exception information [#65](https://github.com/jupyter/nbclient/pull/65)
- Async wapper Exceptions no longer loose their caused exception information [#65](https://github.com/jupyter/nbclient/pull/65)
- `extra_arguments` are now configurable by config settings [#66](https://github.com/jupyter/nbclient/pull/66)

### Operational
Expand Down Expand Up @@ -143,7 +143,7 @@ If you were using these versions for the couple days they were up, move to 0.5.0
### Major Changes

- Async support is now available on the client. Methods that support async have an `async_` prefix and can be awaited [#10](https://github.com/jupyter/nbclient/pull/10) [#35](https://github.com/jupyter/nbclient/pull/35) [#37](https://github.com/jupyter/nbclient/pull/37) [#38](https://github.com/jupyter/nbclient/pull/38)
- Dropped support for Python 3.5 due to async compatability issues [#34](https://github.com/jupyter/nbclient/pull/34)
- Dropped support for Python 3.5 due to async compatibility issues [#34](https://github.com/jupyter/nbclient/pull/34)
- Notebook documents now include the [new kernel timing fields](https://github.com/jupyter/nbformat/pull/144) [#32](https://github.com/jupyter/nbclient/pull/32)

### Fixes
Expand Down
2 changes: 1 addition & 1 deletion nbclient/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def run_notebook(self, notebook_path):
# Get its parent directory so we can add it to the $PATH
path = pathlib.Path(notebook_path).parent.absolute()

# Set the intput file paths
# Set the input file paths
input_path = f"{name}.ipynb"

# Open up the notebook we're going to run
Expand Down
8 changes: 4 additions & 4 deletions nbclient/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def reset_execution_trackers(self) -> None:
# maps to list of hooks, where the last is used, this is used
# to support nested use of output widgets.
self.output_hook_stack: t.Any = collections.defaultdict(list)
# our front-end mimicing Output widgets
# our front-end mimicking Output widgets
self.comm_objects: t.Dict[str, t.Any] = {}

def create_kernel_manager(self) -> KernelManager:
Expand Down Expand Up @@ -729,7 +729,7 @@ async def async_wait_for_reply(
return None

wait_for_reply = run_sync(async_wait_for_reply)
# Backwards compatability naming for papermill
# Backwards compatibility naming for papermill
_wait_for_reply = wait_for_reply

def _passed_deadline(self, deadline: int) -> bool:
Expand Down Expand Up @@ -929,7 +929,7 @@ def output(

parent_msg_id = msg['parent_header'].get('msg_id')
if self.output_hook_stack[parent_msg_id]:
# if we have a hook registered, it will overrride our
# if we have a hook registered, it will override our
# default output behaviour (e.g. OutputWidget)
hook = self.output_hook_stack[parent_msg_id][-1]
hook.output(outs, msg, display_id, cell_index)
Expand Down Expand Up @@ -964,7 +964,7 @@ def clear_output(self, outs: t.List, msg: t.Dict, cell_index: int) -> None:

parent_msg_id = msg['parent_header'].get('msg_id')
if self.output_hook_stack[parent_msg_id]:
# if we have a hook registered, it will overrride our
# if we have a hook registered, it will override our
# default clear_output behaviour (e.g. OutputWidget)
hook = self.output_hook_stack[parent_msg_id][-1]
hook.clear_output(outs, msg, cell_index)
Expand Down
2 changes: 1 addition & 1 deletion nbclient/tests/files/Parallel Execute A.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"# Ensure notebooks can execute in parallel\n",
"\n",
"This notebook uses a file system based \"lock\" to assert that two instances of the notebook kernel will run in parallel. Each instance writes to a file in a temporary directory, and then tries to read the other file from\n",
"the temporary directory, so that running them in sequence will fail, but running them in parallel will succed.\n",
"the temporary directory, so that running them in sequence will fail, but running them in parallel will succeed.\n",
"\n",
"Two notebooks are launched, each which sets the `this_notebook` variable. One notebook is set to `this_notebook = 'A'` and the other `this_notebook = 'B'`."
]
Expand Down
2 changes: 1 addition & 1 deletion nbclient/tests/files/Parallel Execute B.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"# Ensure notebooks can execute in parallel\n",
"\n",
"This notebook uses a file system based \"lock\" to assert that two instances of the notebook kernel will run in parallel. Each instance writes to a file in a temporary directory, and then tries to read the other file from\n",
"the temporary directory, so that running them in sequence will fail, but running them in parallel will succed.\n",
"the temporary directory, so that running them in sequence will fail, but running them in parallel will succeed.\n",
"\n",
"Two notebooks are launched, each which sets the `this_notebook` variable. One notebook is set to `this_notebook = 'A'` and the other `this_notebook = 'B'`."
]
Expand Down
4 changes: 2 additions & 2 deletions nbclient/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ def test_synchronous_setup_kernel():
nb = nbformat.v4.new_notebook()
executor = NotebookClient(nb)
with executor.setup_kernel():
# Prove it initalized client
# Prove it initialized client
assert executor.kc is not None
# Prove it removed the client (and hopefully cleaned up)
assert executor.kc is None
Expand All @@ -420,7 +420,7 @@ def test_startnewkernel_with_kernelmanager():
executor = NotebookClient(nb, km=km)
executor.start_new_kernel()
kc = executor.start_new_kernel_client()
# prove it initalized client
# prove it initialized client
assert kc is not None
# since we are not using the setup_kernel context manager,
# cleanup has to be done manually
Expand Down