Use async generator backport only on old python (#154)

* requirements.txt: Conditionalize async_generator on python_version * client.py: Import asynccontextmanager from contextlib on Python >= 3.7 * mypy.ini: Set python_version = 3.9 to match tox.ini * nbclient/client.py: Suppress a mypy error Co-authored-by: David Brochart <david.brochart@gmail.com> Co-authored-by: David Brochart <david.brochart@gmail.com>
jupyter · Aug 13, 2021 · 61fd479 · 61fd479
1 parent b85aaf3
commit 61fd479
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/mypy.ini b/mypy.ini
@@ -1,7 +1,7 @@
 # Global options:
 
 [mypy]
-python_version = 3.6
+python_version = 3.9
 
 # Per-module options:
 

diff --git a/nbclient/client.py b/nbclient/client.py
@@ -5,7 +5,12 @@
 import signal
 from textwrap import dedent
 
-from async_generator import asynccontextmanager
+try:
+    from contextlib import asynccontextmanager
+except ImportError:
+    # Use the backport package async-generator for Python < 3.7.
+    # This should be removed when nbclient drops support for Python 3.6
+    from async_generator import asynccontextmanager  # type: ignore
 from contextlib import contextmanager
 
 from time import monotonic

diff --git a/requirements.txt b/requirements.txt
@@ -1,5 +1,5 @@
 traitlets>=4.2
 jupyter_client>=6.1.5
 nbformat>=5.0
-async_generator
+async_generator; python_version<'3.7'
 nest_asyncio