Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py and setup.cfg metadata is inconsistent #135

Closed
bnavigator opened this issue Aug 2, 2022 · 2 comments · Fixed by #181
Closed

setup.py and setup.cfg metadata is inconsistent #135

bnavigator opened this issue Aug 2, 2022 · 2 comments · Fixed by #181

Comments

@bnavigator
Copy link
Contributor

I see you copied over the notebook 6 setup.py to nbclassic. Now there are two files with inconsistend metadata in the repository.
@bollwyvl
Copy link
Contributor

Yep, this confused me as well on conda-forge/nbclassic-feedstock#27

@echarles
Copy link
Member

The setup.cfg is only use by the Check Release CI job to generate a hash for the key. The log says e.g.

  with:
    path: /home/runner/.cache/pip
    key: Linux-pip-0af18be079638b7a6856559a469eb62f0aa39d3065d0668e8b50af56daa98de3
    restore-keys: Linux-pip-
  Linux-pip-

setup.cfg is also bundled in the SOURCES.txt.

Would it be OK to simply remove setup.cfg and use setup.py to generate the hash?

@echarles echarles mentioned this issue Nov 3, 2022
Closed
@echarles echarles mentioned this issue Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align setup.py and setup.cfg datalayer-externals/jupyter-notebook-classic
3 participants
@bollwyvl @echarles @bnavigator