Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StopWatch does not need to be Abstract #1110

Closed
Tibor17 opened this issue Apr 2, 2015 · 8 comments
Closed

StopWatch does not need to be Abstract #1110

Tibor17 opened this issue Apr 2, 2015 · 8 comments
Milestone

Comments

@Tibor17
Copy link
Contributor

Tibor17 commented Apr 2, 2015

The StopWatch is abstract without any abstract method. I am forced to extend this class even if not necessary.
Can we remove the modifier?

@Tibor17
Copy link
Contributor Author

Tibor17 commented Apr 3, 2015

@kcooney
@dsaff
@marcphilipp
@stefanbirkner
Any thoughts?

@kcooney
Copy link
Member

kcooney commented Apr 3, 2015

I don't have any objections.

BTW, is there a reason why you needed a quick response? You created this issue less than a day ago

@marcphilipp
Copy link
Member

Is there a usecase when it's not necessary to extend this class?

@Tibor17
Copy link
Contributor Author

Tibor17 commented Apr 3, 2015

We can commit in 4.13, no hurry; but usully you are fast to response so it looked like you did forget this.
I created StopWatch in JUnit and now I am using it in my company and wondering about the modifier. I will replace the Stopwatch in surefire with this one but new StopWatch() {} isn't so nice in the code.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Apr 3, 2015

If measuring exec time, I don't need other notifications, only reading the runtime.

@kcooney
Copy link
Member

kcooney commented Apr 4, 2015

@Tibor17 although we often respond to issues quickly, we all have day jobs :-) If we don't respond to issues within a few weeks, feel free to ping the issues.

@marcphilipp
Copy link
Member

I forgot about runtime being public, never mind. No objections from me either.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Apr 4, 2015

The PR #1111 was created.

@stefanbirkner stefanbirkner added this to the 4.13 milestone Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants