Archive projects #236
Archive projects #236
Conversation
|
@julien-nc did some more cosmetic stuff... now you can test it. |
There was a problem hiding this comment.
Super nice! Thanks a lot for the PR. 💙
Sorry I have a lot of change requests. I made suggestions for most of them.
Mainly:
- I think we should use a timestamp to store the archived date
- The mixin does not work, let's go with an event to trigger a call to the deselectProject method in
App
Ok
Ah, some comments where hidden... Do I need to do something? 😅 |
What do you mean? 😁 |
I'm not sure what I have to do now ^^ I accepted all your changes and commited them. Is there something left to do for me? |
There was a problem hiding this comment.
Is there something left to do for me?
Yes:
- fix
lib/Db/Project.php(see suggestion) - If you're fine with my opinion on the mixin: get rid of it, bring back the deselectProject method in
App, subscribe to the event and call the deselectProject method.
I can also push some commits in your branch, as you wish.
Then you should probably finish it. Next time I'll ask/discuss beforehand how to resolve the problem (like using timestamp instead of datetime) to not play ping pong. |
|
Alright, thanks for being open to my suggestions. |
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
archive-projects
branch
from
83b6c9e
to
55fe823
Compare
Hi @julien-nc, I've implemented the functionality for archiving projects and unarchiving them.
You can view the functionality here:
2023-12-01_232014.mp4
To identify which project is archived I've used DateTime. I want to show when the project was archived soon.
In the near future, I plan to add:
Fixes: #128