Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #63

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Add support for Python 3.11 #63

merged 5 commits into from
Nov 21, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 20, 2022

Python 3.11 was released on 2022-10-24 🚀

image

Also allow other jobs to continue if one job fails (lets us see if it's just 3.6 is having problems or all of them)

And bump GitHub Actions.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 20, 2022

Passed on my fork 🤷

https://github.com/hugovk/Products.ZopeTree/actions/runs/3509363286

At least we know it's not from old actions and it is unique to 3.6... (And 3.11 passes 🎉)

https://github.com/jugmac00/Products.ZopeTree/actions/runs/3509370534/jobs/5878427857

This looks relevant to "Version 3.6 was not found in the local cache":

actions/setup-python#544

@hugovk
Copy link
Contributor Author

hugovk commented Nov 20, 2022

@hugovk
Copy link
Contributor Author

hugovk commented Nov 20, 2022

Yep, looks like 3.6 isn't on any of the 22.04 images:

https://github.com/raw/actions/python-versions/main/versions-manifest.json

So either use 20.04 for all Python versions (until dropping 3.6) or adjust the matrix to only use ubuntu-20.04 for 3.6 and ubuntu-latest for the others, and/or wait for a resolution to actions/setup-python#544.

(I'd go for the simplicity of option 1.)


Edit: and I can repro the failure in my fork on another branch when pinning to 22.04:
https://github.com/hugovk/Products.ZopeTree/actions/runs/3509410199 👍

@jugmac00
Copy link
Owner

Thanks @hugovk! Great catch!

@jugmac00 jugmac00 merged commit 2da9284 into jugmac00:master Nov 21, 2022
@hugovk hugovk deleted the update-ci branch November 21, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants