Card cover #93
Closed
Card cover #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for picking up this, looks very good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for staging only and discussion and will not be merged
Summary
This is my simple implementation of card cover images, inspired by the CoverImage feature of deck Android app:
I placed the option alongside compact mode and it enabled/disables the option globaly (even for the upcoming cards view):
This is the normal board view, ...
with compact mode I'm deviating from the android app, because if there is a due date and I would add the image to the left of the card (like proposed in nextcloud#2858), ... there isn't very much space left for the card title.
And finaly the mobile view:
TODO