Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for invalid use of fragments in "$id" #299

Closed
4 tasks
handrews opened this issue Nov 11, 2019 · 3 comments · Fixed by #341
Closed
4 tasks

Test for invalid use of fragments in "$id" #299

handrews opened this issue Nov 11, 2019 · 3 comments · Fixed by #341
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Milestone

Comments

@handrews
Copy link
Contributor

handrews commented Nov 11, 2019

  • fragment-only plain name: "$id": "#foo"
  • fragment-only JSON Pointer: "$id": "#/a/b"
  • URI with at least one other component plus a non-empty plain name fragment
  • URI with at least one other component plus a non-empty JSON Pointer name fragment
@handrews handrews added this to the 2019-09 milestone Nov 11, 2019
@Julian Julian added the missing test A request to add a test to the suite that is currently not covered elsewhere. label Nov 29, 2019
@karenetheridge
Copy link
Member

Take care -- that first one, "$id": "#foo", is legal in draft7, but not 2019-09 (moved to $anchor). I would just copy some tests out of tests/draft7/refRemote.json and s/valid/invalid/ as appropriate.

@ssilverman
Copy link
Member

@karenetheridge did you mean ref.json and not refRemote.json? I see fragments in the first but not the second.

@karenetheridge
Copy link
Member

@ssilverman I expect I was looking at an outdated version of the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Projects
None yet
4 participants