Internationalization issues

[meskobalazs]

These two strings are not great to translate:

jslirola-login2seeplus.forum.post:

flarum-ext-login2seeplus/js/src/forum/index.js

Line 65 in 14257e2

newContent += '<div class="jslirolaLogin2seeplusAlert">' + app.translator.trans('jslirola-login2seeplus.forum.post',

jslirola-login2seeplus.forum.post_login:

flarum-ext-login2seeplus/src/HideContentInPosts.php

Line 66 in 14257e2

$newHTML .= '<div class="jslirolaLogin2seeplusAlert">' . $this->translator->trans($key,$args) . '</div>';

In some languages (e.g. in Hungarian in my case) we would like to use conjugation/declension with the Log in and Register string, but currently this is not possible.

[jslirola]

@meskobalazs

Do you have an example of this in another extension to take a look? I'm not sure how to do it yet but I will try to help you.

Have you tried using your own translation with the 'FoF Linguist' extension?

[meskobalazs]

In hindsight I should have been more specific. My issue is that the code is reusing strings it should. In this case:

newContent += '<div class="jslirolaLogin2seeplusAlert">' + app.translator.trans('jslirola-login2seeplus.forum.post',
{
    login: "<a class='jslirolaLogin2seeplusLogin'>" + app.translator.trans('core.forum.header.log_in_link') + "</a>",
    register: "<a class='jslirolaLogin2seeplusRegister'>" + app.translator.trans('core.forum.header.sign_up_link') + "</a>"
}).join('') + '</div>';

core.forum.header.log_in_link and core.forum.header.sign_up_link comes from core, and it works fine in English, because it has the same form as a label and in sentence, but this is not universal. The other string is also similar.

I think that the best course of action would be spelling out the whole string, and not try to optimize it, so jslirola-login2seeplus.forum.post should not contain variables. I get that it causes redundancy, but it makes the life of translators easier, piecemeal strings are usually a bad idea.

By the way I fixed my issue with a workaround, so it's not like I am unable to translate the extension, it just would be better if I did not have to do this.

PS: If you are still unsure what I mean, I can send you a PR.

[jslirola]

Thank you for such detailed information.

If you don't mind, create a Draft PR and I will take a look. Also you could include a new .yaml file with your language to contain the best translation considering you are native (I guess).

Next week I'll try to complete this issue to include a new string so we can work together on the same PR to fix both at the same time:

#23