You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some languages (e.g. in Hungarian in my case) we would like to use conjugation/declension with the Log in and Register string, but currently this is not possible.
The text was updated successfully, but these errors were encountered:
core.forum.header.log_in_link and core.forum.header.sign_up_link comes from core, and it works fine in English, because it has the same form as a label and in sentence, but this is not universal. The other string is also similar.
I think that the best course of action would be spelling out the whole string, and not try to optimize it, so jslirola-login2seeplus.forum.post should not contain variables. I get that it causes redundancy, but it makes the life of translators easier, piecemeal strings are usually a bad idea.
By the way I fixed my issue with a workaround, so it's not like I am unable to translate the extension, it just would be better if I did not have to do this.
PS: If you are still unsure what I mean, I can send you a PR.
If you don't mind, create a Draft PR and I will take a look. Also you could include a new .yaml file with your language to contain the best translation considering you are native (I guess).
Next week I'll try to complete this issue to include a new string so we can work together on the same PR to fix both at the same time:
These two strings are not great to translate:
jslirola-login2seeplus.forum.post:
flarum-ext-login2seeplus/js/src/forum/index.js
Line 65 in 14257e2
jslirola-login2seeplus.forum.post_login:
flarum-ext-login2seeplus/src/HideContentInPosts.php
Line 66 in 14257e2
In some languages (e.g. in Hungarian in my case) we would like to use conjugation/declension with the Log in and Register string, but currently this is not possible.
The text was updated successfully, but these errors were encountered: