Use js-sys regex type on wasm32-unknown-unknown with feature enabled
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hacked together a small regex test that doesn't use the |
jprochazk
reviewed
Nov 4, 2023
jprochazk
reviewed
Nov 4, 2023
|
i know it's a draft, just threw in some drive-by comments |
|
So, it's now looking more cleaned up, the regex is cached between invocations, and there is a new CI step |
jprochazk
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still missing a workflow to run the tests in CI but they should work
Edit:
instajust doesn't work withwasm-bindgen-test, so testing is not really feasible with the current test setup