Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Remove Existing SECRETS and add only the new #19

Closed
varunsridharan opened this issue Jun 29, 2020 · 5 comments
Closed

Auto Remove Existing SECRETS and add only the new #19

varunsridharan opened this issue Jun 29, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@varunsridharan
Copy link

I recently started using this action to my certain SECRETS available to repos.

but then i found out that this action does not remove Existing SECRETS

Let me give you an example

I have configured my workflow like below

      - name: "馃攧 Sync Twitter Logins"
        uses: google/secrets-sync-action@v1.4.1
        with:
          repositories_list_regex: false
          SECRETS: |
            ^TWITTER_
          REPOSITORIES: ${{ env.TWITTER_LOGINS_REPOS }}
          DRY_RUN: ${{ env.DRY_RUN }}
          CONCURRENCY: ${{ env.CONCURRENCY }}
          GITHUB_TOKEN: ${{ secrets.GH_PUBLIC_PRIVATE_TOKEN }}

and i have below EVN's configured

env:
  DRY_RUN: false
  CONCURRENCY: 50
  TWITTER_API_KEY: ${{ secrets.TWITTER_API_KEY }}
  TWITTER_API_SECRET_KEY: ${{ secrets.TWITTER_API_SECRET_KEY }}
  TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
  TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
  TWITTER_LOGINS_REPOS: |
    varunsridharan/****
    varunsridharan/****
    varunsridharan/****
    varunsridharan/****
    varunsridharan/****

And when i ran the action to syn ll the SECRETS it also added TWITTER_LOGINS_REPOS to the repo

https://s2.do-spaces.com/2020/Jun/29/1593409947-114.jpg

I know its my mistake i should have configured the Regex Properly ..

but i would be great if this action and force remove all the matching SECRETS and add only the new matched SECRETS !

@mastermind369
Copy link

#15

@varunsridharan
Copy link
Author

@mastermind369 i tried with latest version. but it did not delete it :-( !! Confused.

@mastermind369
Copy link

mastermind369 commented Jul 1, 2020

I'm trying to find your account again. if this doesn't work I'm sorry, I'm just trying.

@jpoehnelt
Copy link
Owner

There is no delete mechanism.

@jpoehnelt jpoehnelt added the enhancement New feature or request label Jul 7, 2020
@jpoehnelt
Copy link
Owner

Closing with #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants
@varunsridharan @jpoehnelt @mastermind369 and others