Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Replace :D with 😄 instead of 😃 #635

Closed
MightyCreak opened this issue Dec 19, 2018 · 1 comment
Closed

Replace :D with 😄 instead of 😃 #635

MightyCreak opened this issue Dec 19, 2018 · 1 comment

Comments

@MightyCreak
Copy link

Riot.im uses emojione and the auto-replacement of ascii strings to emoji (i.e. :) becoming 🙂).

I think :D should not be converted to 😃 (:smiley:) but rather to 😄 (:smile:).
In all the apps I use (e.g. Riot, Github and Slack), 😃 looks more like a "surprise" than a "it's funny".

And, actually, Slack uses :smile: for :D.
And it also seems more logical to replace :D with :smile:, since :) is replaced by :slight_smile: (no y in the end).

I've tried to change the code in order to propose a PR, but I'm unsure which file I should really change... Is it emoji.js?

@MightyCreak MightyCreak changed the title Use 😄 instead of 😃 for :D auto-replacement Replace :D with 😄 instead of 😃 Dec 19, 2018
@caseyahenson
Copy link
Contributor

This is fixed in the 5.0 release https://github.com/joypixels/emoji-toolkit/releases/tag/5.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants