NODE_PATH parses on ':' instead of ';'

[beriberikix]

NODE_PATH fails on windows since absolute paths start with 'C:/' and currently does process.env.NODE_PATH.split(":"). PATH on windows should be delimited by ';'.

[felixge]

@ry: You mentioned you want all plattform stuff in uv, is that also the case here? If so what would be the solution? A binding to split paths?

[isaacs]

It's a pretty trivial fix. isaacs/node@e78a626a6e32f5cc9cb2

@ry @piscisaureus @felixge Care to comment?

[felixge]

I'm fine with the patch, it's nice and simple. @ry just mentioned he wants all plattform stuff in libuv, so it's his call I guess.

[piscisaureus]

@felixge
I think we have to make an exception for this. Going through the C++ layer for something simple like this seems stupid. Also many functions in node_lib/path.js already have a platform-specific implementation.

@isaacs
We might consider adding some 'constant' for this, e.g. require('path').PATH_SEPARATOR. This is also what php does -- although I always found the difference between PATH_SEPARATOR (: or ;) and DIR_SEPARATOR (\ or /) a bit confusing.

[ry]

yes, going through the c++ layer for this seems stupid. +1

[isaacs]

The ayes have it.

[TooTallNate]

Though still a +1 for require('path').PATH_SEPARATOR from me. Seems essential.

[DrPizza]

Java also does a similar thing for path/directory separators. I think it would be a useful thing to expose to users.

[ry]

require('path').SEPARATOR sounds fine.

[DrPizza]

It may be nice to have a filesystem separator too, though perhaps in a different module.