Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing API to use higher order functions to inject the state stream or store #24

Open
joshburgess opened this issue Sep 5, 2017 · 4 comments

Comments

@joshburgess
Copy link
Owner

joshburgess commented Sep 5, 2017

I wanted to get the new API release out, so I held off on rewriting with higher order functions. I might still do it in the future, so I'm creating an issue here to remind myself to come back to the idea to see if it's worth another breaking change.

Link to previous conversation: #4

@kanitsharma
Copy link

@joshburgess I really really like this idea of higher order functions, and since updating to @most/core may need us to bump the version how about we roll this feature out too? 😄

@joshburgess
Copy link
Owner Author

@kanitsharma If you have any time to do a PR for it (or just prototype an idea for me to look at), that would be cool.

I also never added the capability to inject dependencies (like an API client), which is probably something people miss from other libraries.

I'm open to any other ideas you might have for improvements also.

@kanitsharma
Copy link

@joshburgess Sure 👍 I will send a PR.

@kanitsharma
Copy link

PR #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants