fix: load seeders classes using typeorm (#324) #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2024
|
I also tested this build in my repo (>100 seeders) and it works fine. Also, since it relies on TypeORM loading the classes, there's no need to use default exports. |
alumni
force-pushed
the
fix/load-seeder-classes-using-typeorm
branch
from
eb79f0a
to
7b79a3c
Compare
alumni
force-pushed
the
fix/load-seeder-classes-using-typeorm
branch
from
7b79a3c
to
9b58477
Compare
|
@jorgebodega Could you please review this PR? FYI, I left the formatting in package.json unchanged on purpose, but I can also fix it easily if need be. |
|
I'll check this later, and if you can fix the format step would be great! |
alumni
force-pushed
the
fix/load-seeder-classes-using-typeorm
branch
from
9e3f4da
to
56153a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324 by loading the seeder classes in the same way typeorm loads entities, subscribers or migrations classes.