-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use TS Config presets to transpile correctly #325
Conversation
a12ff86
to
c837bda
Compare
c837bda
to
0aecc54
Compare
Thanks @alumni for making this fix. Quick question: Is there a reason this is not merged yet? I'm currently having the same issue referenced in this PR, i:e #324 I'd also like to know if there is a workaround for this while this PR is not merged yet cc: @jorgebodega |
I'm going to try to create a new PR with some changes of this one and some other changes, and merge this weekend. And probably, those changes are going to be ported to https://github.com/jorgebodega/typeorm-factory as well |
Please, try the new version 7.1.0-next.1 and check if that works for all of you. If not, please comment here and we can try to find the solution together. |
I'm getting this:
|
Can you give more information or create a minimal reproduction of the error? |
@jorgebodega The issue that I see is in In v6, the dynamic import was transpiled to a require which seemed to work, not sure why one works and the other not. I'll try to investigate a bit more. |
I will close this PR since this was fixed already in the The issue that remains is that NodeJS can't dynamically import CommonJS modules (it's what TypeORM itself is using a utility function for supporting any kind of import: |
Fixes #324