Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert Measure class to enum #181

Open
wants to merge 1 commit into
base: php8
Choose a base branch
from
Open

convert Measure class to enum #181

wants to merge 1 commit into from

Conversation

jordanbrauer
Copy link
Owner

Types of changes

What types of changes does your code introduce? Check/place an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Description

WIP

Motivation and Context

upgrading to modern php and adopting it's features

How Has This Been Tested?

unit tests

Screenshots:

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant