Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Mfa: Setting timezone for dates in profile #43191

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 1, 2024

Pull Request for Issue #41003 .

Summary of Changes

When a user does not have a timezone set and the multifactorauthentication is enabled, the timestamps shown in the profile are not in the timezone of the site, but in UTC.

Testing Instructions

  1. Set the timezone of your site in the global configuration to something else than UTC so that you have an offset to UTC.
  2. Create a user and enable Mfa for that user, for example the fixed code Mfa, which you can enable in the Mfa plugins. Leave the timezone at "Default".
  3. Login to the frontend with that user and go to its profile

Actual result BEFORE applying this Pull Request

The datetimes in the Mfa methods box are in UTC.

Expected result AFTER applying this Pull Request

The datetimes in the Mfa methods box are in the timezone of the site.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Copy link
Member

@laoneo laoneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually thw correct way to determine the timezone.

@exlemor
Copy link

exlemor commented Apr 3, 2024

I have tested this item ✅ successfully on 948e765

I was able to test this successfully :)

At least for me, I was not able to add MFA from the Backend User Area therefore, the description should be updated:
Make sure you turn on Profile Link in the Login Form module (otherwise you won't be able to add MFA from the Front End).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43191.

@alikon
Copy link
Contributor

alikon commented Apr 4, 2024

I have tested this item ✅ successfully on 948e765


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43191.

@alikon
Copy link
Contributor

alikon commented Apr 4, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43191.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 4, 2024
@laoneo laoneo added this to the Joomla! 4.4.4 milestone Apr 5, 2024
@laoneo laoneo merged commit b8d58e7 into joomla:4.4-dev Apr 5, 2024
4 checks passed
@laoneo
Copy link
Member

laoneo commented Apr 5, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.4-dev and removed RTC This Pull Request is Ready To Commit labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants