Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] DARK MODE installer drag and drop #43018

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

add css and change to [data-bs-theme-dark]

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Mar 12, 2024
@brianteeman brianteeman changed the title [5.1] installer drag and drop [5.1] DARK MODE installer drag and drop Mar 12, 2024
@Fedik
Copy link
Member

Fedik commented Mar 13, 2024

I think use of data-color-scheme would be preferable, in non BS files.

@brianteeman
Copy link
Contributor Author

i would but it doesnt work

@Fedik
Copy link
Member

Fedik commented Mar 13, 2024

Okay then :)

@brianteeman
Copy link
Contributor Author

maybe it was me and someone else can get it to work

@Fedik
Copy link
Member

Fedik commented Mar 14, 2024

@brianteeman I made a quick check and data-color-scheme works to me:

[data-color-scheme=dark] #dragarea.hover #upload-icon,
[data-color-scheme=dark] #dragarea p.lead {
  color: #eee;
}

[data-color-scheme=dark] #dragarea.hover {
  background-color: #666;
  border-color: #eee;
}

@brianteeman
Copy link
Contributor Author

I will take another look. Probably did something daft

@brianteeman
Copy link
Contributor Author

@Fedik updated as requested

@Fedik
Copy link
Member

Fedik commented Mar 14, 2024

I have tested this item ✅ successfully on 9d48656


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43018.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 14, 2024

I have tested this item ✅ successfully on 9d48656


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43018.

@Quy
Copy link
Contributor

Quy commented Mar 14, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43018.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 14, 2024
@LadySolveig LadySolveig merged commit f22e56b into joomla:5.1-dev Mar 14, 2024
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 14, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Mar 14, 2024
@brianteeman brianteeman deleted the drag_drop branch March 14, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Dark Mode NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants