-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Smart Search: Properly sort filters #42835
Conversation
I have tested this item ✅ successfully on 55139c2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
@Hackwar Shouldn’t this be fixed in the 4.4-dev branch? The issue was reported for 4.3. |
@richard67 See the last discussion we had about this. Nothing has changed since then. |
@Hackwar So you think you as the JBS Team Lead and a member of the CMS Maintenance Team can do as you like and ignore all our policies? |
I'm not ignoring policies. However I refuse to waste my time arguing if something is a bug and worthy of fixing in Joomla 4.4 and rather take the shortcut of providing that fix to 5.0+. Since the relevant maintainer decided to ignore this for over a week now as well, I'm assuming that it is fine the way I'm doing it. |
I have tested this item ✅ successfully on 55139c2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
RTC as it has 2 successful tests. Release managers pls. decide if it should go into 5.0-dev or 4.4-dev. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
55139c2
to
70f6b1a
Compare
I've tested this on J5.1. I created some categories and subcategories in content and in contacts. I deliberately named some of the categories in contact and content categories the same. After some testing the search didn't work for content anymore. Even if I turn of all other search plugins, and leave content the only one turned on. I did rebuild the smart search index. The advanced search does show the content categories, but whatever search word I enter, there's no result. If I turn on search for contacts, the contacts will be found, but no articles will show up. I revoked the patch, and still the content search doesn't work anymore. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
Back to pending after rebase. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
With J 5.1, the display after patching does not change. ##ACCESSIBILITY IDEA |
@stimpsonjcat Your issues are unrelated to this PR. This PR only touches the order of the entries in the filters. @adj9 That is already an option in the component configuration of Smart Search. Also,if you only have 2 categories, there is nothing which could change, since they aren't out of order at that moment. |
I did test it again. It seemed that my articles had disappeared on the pizza-bugs-and-fun server. The only feature request I would suggest: if you have a top level category (i.e. red) and and a sublevel category (i.e. light red), I would expect, as an enduser, if I search in the top-level I would also find results in the sublevel. |
@stimpsonjcat Could you use the blue "Test this" button in the issue tracker https://issues.joomla.org/tracker/joomla-cms/42835 to submit your test result? Otherwise it is not counted. Thanks in advance. |
I have tested this item ✅ successfully on 4a8e9a1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
I have tested this item ✅ successfully on 4a8e9a1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
administrator/components/com_finder/src/Service/HTML/Filter.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Just to be safe: can we have another test here? |
Back to pending This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
No good! With the patch applied I see the list in order but part of the Sample Data Articles is repeated. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
Why do you want another test for this? |
@ceford can you please be a bit more specific? What do you see repeated where? |
I'm getting errors in Joomla 5.1.0-alpha4: Warning: Undefined property: stdClass::$id in /administrator/components/com_finder/src/Indexer/Result.php on line 576 Warning: Attempt to read property "state" on array in /administrator/components/com_finder/src/Indexer/Result.php on line 577 Warning: Attempt to read property "access" on array in /administrator/components/com_finder/src/Indexer/Result.php on line 578 |
@stimpsonjcat How is this related to this PR here which is clearly made for 4.4-dev and not 5.1-dev? |
I have tested this item ✅ successfully on ded674e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835. |
As we added only a type to a function argument, one test is enough. So merging it as it was RTC before. |
Thanks! |
Pull Request for Issue #41930.
Summary of Changes
The entries in the filters in Smart Search aren't properly ordered in the frontend.
Testing Instructions
Actual result BEFORE applying this Pull Request
The categories are pretty much random.
Expected result AFTER applying this Pull Request
The categories are displayed properly like in the tree structure.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed