Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Update deleted files list in script.php for 5.1.0-alpha4 #42785

Conversation

richard67
Copy link
Member

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of files and folders to be deleted on update in script.php by the PHP files from PRs #42355 and #42214 for the next alpha release (5.1.0-alpha4).

There are no other deleted files and folders to be added to the lists up to now.

Javascript files removed with PRs like e.g. #42082 and #42423 will not be added to the list because we don't want to delete them on update for b/c reasons, see PR #42567 . I will create a separate PR to add them to the list of exceptions in file build/deleted_file_check.php so they will not be reported by that tool.

Testing Instructions

Code review.

Or update from 4.4.x or 5.0.x to the latest 5.1 nightly for the actual result and to the patched update package or custom update URL created by Drone for this PR for the expected result.

Actual result BEFORE applying this Pull Request

The files added by this PR to the list in script.php are still present after the update.

Expected result AFTER applying this Pull Request

The files added by this PR to the list in script.php have been deleted with the update.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title [5.1] Update deleted files and folders lists in script.php for 5.1.0-alpha4 [5.1] Update deleted files list in script.php for 5.1.0-alpha4 Feb 11, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 11, 2024
@LadySolveig LadySolveig merged commit fafcd5f into joomla:5.1-dev Feb 11, 2024
3 checks passed
@richard67 richard67 deleted the 5.1-dev-deleted-files-and-folders-2024-02-10 branch February 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants