Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[5.0] Switching Input object from CMS to framework class" #42764

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

LadySolveig
Copy link
Contributor

Reverts #40415 b/c

@wilsonge
Copy link
Contributor

wilsonge commented Feb 5, 2024

What is this fixing? The majority of these things are doc blocks changes (and are probably required in advance of us swapping things over in J6 or similar). The two places I can see potential real impacts are BaseApplication and WebApplication where we change the default instance over. Targeted fixes might be better there depending on exactly what b/c things have been reported.

@LadySolveig
Copy link
Contributor Author

Revert only because of the complete replacement of class Joomla\Input\Input <-> Joomla\CMS\Input\Input - not the doc block changes.

@bembelimen bembelimen merged commit ef8bc6a into 5.1-dev Feb 6, 2024
5 checks passed
@bembelimen bembelimen deleted the revert-40415-5.0-input branch February 6, 2024 08:13
@bembelimen
Copy link
Contributor

Thanks

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Feb 6, 2024
@wilsonge
Copy link
Contributor

wilsonge commented Feb 6, 2024

Revert only because of the complete replacement of class Joomla\Input\Input <-> Joomla\CMS\Input\Input - not the doc block changes.

I understand but as Joomla\CMS\Input\Input extends from Joomla\Input\Input there isn't a b/c break. the b/c breaks are only where we create the class (because the internals aren't set by reference), widening the type hints shouldn't be a b/c break and in some cases may allow people to do easier interop going into the change default happening in J6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants