Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] TinyMCE 5.10.9 #42359

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[4.4] TinyMCE 5.10.9 #42359

merged 2 commits into from
Nov 23, 2023

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Nov 17, 2023

This is a security release

Version 5.10.9 - November 15, 2023

Changed

  • Zero width no-break space (U+FEFF) characters are removed from content passed to setContent, insertContent, and resetContent APIs.
  • Zero width no-break space (U+FEFF) characters in initial content are not loaded into the editor upon initialization.

Fixed

  • Specific HTML content containing unescaped text nodes caused mXSS when using undo/redo.
  • Specific HTML content containing unescaped text nodes caused mXSS when using the getContent and setContent APIs with the format: 'raw' option, which also affected the resetContent API and the draft restoration feature of the Autosave plugin

This is a security release

## Version 5.10.9 - November 15, 2023
### Changed
- Zero width no-break space (U+FEFF) characters are removed from content passed to setContent, insertContent, and resetContent APIs.
- Zero width no-break space (U+FEFF) characters in initial content are not loaded into the editor upon initialization.
### Fixed
-Specific HTML content containing unescaped text nodes caused mXSS when using undo/redo.
-Specific HTML content containing unescaped text nodes caused mXSS when using the getContent and setContent APIs with the format: 'raw' option, which also affected the resetContent API and the draft restoration feature of the Autosave plugin
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev labels Nov 17, 2023
@brianteeman
Copy link
Contributor Author

Note a similar update is required for tiny6 and joomla5 but I cant create it due to this bug #42356

@Fedik
Copy link
Member

Fedik commented Nov 21, 2023

I have tested this item ✅ successfully on 7031c0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42359.

@wilsonge
Copy link
Contributor

Just noting that I see the TinyMCE6 update has been done directly with ba3fa03

@SniperSister
Copy link
Contributor

I have tested this item ✅ successfully on 7031c0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42359.

@brianteeman
Copy link
Contributor Author

Just noting that I see the TinyMCE6 update has been done directly with ba3fa03

Grrh

@Quy
Copy link
Contributor

Quy commented Nov 21, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42359.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 21, 2023
@HLeithner HLeithner added the bug label Nov 23, 2023
@MacJoom MacJoom merged commit 49be844 into joomla:4.4-dev Nov 23, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 23, 2023
@brianteeman brianteeman deleted the tinymce branch November 23, 2023 09:41
@MacJoom MacJoom added this to the Joomla! 4.4.1 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants