[5.0] Fix URLs and hardcoded keyName for editing URL, in ModalSelectField #42346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Adds Route::_() for URLs to make sure they are corectly prefixed with a base URL.
Fix hardoced keyName
id
to allow other var name.Testing Instructions
Run
npm install
Add the field somewhere, example in mod_custom:
Then open the form and click Edit button.
Check the popup content.
Also check the iframe url, in the browser console.
Actual result BEFORE applying this Pull Request
Depend from installation, you wil get 404 not found (for installations in subfolder) or home page.
Iframe url containe
&id=1
Expected result AFTER applying this Pull Request
You get dashboard in popup.
Iframe url containe
&foo=1
Link to documentations
Please select:
Reference;