Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix URLs and hardcoded keyName for editing URL, in ModalSelectField #42346

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 15, 2023

Pull Request for Issue # .

Summary of Changes

Adds Route::_() for URLs to make sure they are corectly prefixed with a base URL.
Fix hardoced keyName id to allow other var name.

Testing Instructions

Run npm install

Add the field somewhere, example in mod_custom:

<field 
    type="ModalSelect"
    name="test"
    label="Test"
    default="1"
    urlSelect="index.php?tmpl=component"
    urlEdit="index.php?tmpl=component"
    edit="true"
    data-key-name="foo"
/>

Then open the form and click Edit button.
Check the popup content.
Also check the iframe url, in the browser console.

Actual result BEFORE applying this Pull Request

Depend from installation, you wil get 404 not found (for installations in subfolder) or home page.
Iframe url containe &id=1

Expected result AFTER applying this Pull Request

You get dashboard in popup.
Iframe url containe &foo=1

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference;

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Nov 15, 2023
@Fedik Fedik changed the title [5.0] Fix URLs and hardoced keyName for editing URL [5.0] Fix URLs and hardoced keyName for editing URL, in ModalSelectField Nov 15, 2023
@Fedik Fedik changed the title [5.0] Fix URLs and hardoced keyName for editing URL, in ModalSelectField [5.0] Fix URLs and hardcoded keyName for editing URL, in ModalSelectField Nov 15, 2023
@Fedik Fedik added the bug label Nov 15, 2023
@HLeithner
Copy link
Member

thanks, really appreciated.

@HLeithner
Copy link
Member

I have tested this item ✅ successfully on e10dd4a

works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42346.

@chmst
Copy link
Contributor

chmst commented Nov 18, 2023

I have tested this item ✅ successfully on e10dd4a

Tested following testing instructions. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42346.

@chmst chmst removed NPM Resource Changed This Pull Request can't be tested by Patchtester bug PR-5.0-dev labels Nov 18, 2023
@chmst
Copy link
Contributor

chmst commented Nov 18, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42346.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 18, 2023
@bembelimen bembelimen merged commit c8ea946 into joomla:5.0-dev Nov 18, 2023
4 checks passed
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev and removed RTC This Pull Request is Ready To Commit labels Nov 18, 2023
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.0.1 milestone Nov 18, 2023
@Fedik Fedik deleted the fix-modalselect-urls-and-var branch November 18, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants