[4.4] Node 20 #42331
Merged
[4.4] Node 20 #42331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrammatiko
requested review from
laoneo,
chmst,
bembelimen,
HLeithner,
rdeutz,
Hackwar and
zero-24
as code owners
joomla-cms-bot
added
Language Change
joomla-cms-bot
added
PR-4.4-dev
and removed
Language Change
|
This PR fixes this issue: #42325 (comment) I could reproduce it locally on an Ubuntu VM and have verified that it's fixed on the branch of this PR. For fixing the currently failing 4.4-dev nightly build it will need this PR here and in addition joomla-projects/docker-images#72 . |
richard67
approved these changes
Nov 11, 2023
|
Thanks all for the quick fix. |
|
@laoneo please also commit joomla-projects/docker-images#72 to fix the packager. Right now it's (probably) still broken: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42265 (back porting to 4.4) .
Summary of Changes
Testing Instructions
Run npm ci, everything still works
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed