Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 42229 - webservices content patch tags lost #42233

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

MacJoom
Copy link
Contributor

@MacJoom MacJoom commented Oct 27, 2023

Pull Request for Issue #42229.

Summary of Changes

Tags are not saved on a webservices content patch

Testing Instructions

Use webservices api to save (patch) an article

Actual result BEFORE applying this Pull Request

tags are gone

Expected result AFTER applying this Pull Request

tags are still the same

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

richard67 commented Oct 27, 2023

@MacJoom When you refer to an issue at the top of the PR, please do it right (no space between the hash character and the issue number) so the issue is properly linked and we can see in the issue that it is referred to by a PR. This makes it easier for us to find issues which have a PR so we can close them. In addition, if you have the privileges to close issues, close the corresponding issue when you made a PR. Thanks in advance.

@alikon
Copy link
Contributor

alikon commented Oct 28, 2023

I have tested this item ✅ successfully on 8217de5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42233.

@woluweb
Copy link
Contributor

woluweb commented Oct 29, 2023

I have tested this item ✅ successfully on 8217de5

Txs Martin!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42233.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42233.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 29, 2023
@richard67 richard67 added this to the Joomla! 4.4.1 milestone Oct 29, 2023
@laoneo laoneo merged commit 8ec5c35 into joomla:4.4-dev Oct 31, 2023
2 of 3 checks passed
@laoneo
Copy link
Member

laoneo commented Oct 31, 2023

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 31, 2023
@MacJoom MacJoom deleted the issue-webservices-articles-tags-lost branch April 12, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants