[5.0] Fix legacy table creation

[HLeithner]

Pull Request for Issue #42179 .

Summary of Changes

If a legacy table is created by Table::getInstance() twice it fails the second time. Reason for this is that the legacy table name is not used if the table class already exists.

Testing Instructions

Test joomla core and a random 3rd party extension which uses tables

Actual result BEFORE applying this Pull Request

Could fail if Table::getInstance() is called more then 1 time for the same old (JTableXXX) syntax.

Expected result AFTER applying this Pull Request

works

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[laoneo]

Did you change something in the code? Only intendation is added.

[Quy]

Add w=1 to hide whitespace changes. https://github.com/joomla/joomla-cms/pull/42180/files?w=1

[laoneo]

Thanks, I was sure that I miss here something :-)

[HLeithner]

@georgebara can you please test this pr?

[georgebara]

Thank you for the fast feedback.

[richard67]

@georgebara Was your approval a real successful test? If so, please mark your test result so it's properly counted. For doing this, go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/42180 , then use the blue "Test this" button at the top left corner, then select your test result and finally submit. Thanks in advance.

[georgebara]

I have tested this item ✅ successfully on 6265a1b

The issue could not be reproduced anymore.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42180.}

[viocassel]

I have tested this item ✅ successfully on 6265a1b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42180.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42180.}

[bembelimen]

Thx