-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] resolve todo image filter #41885
[5.1] resolve todo image filter #41885
Conversation
As we are now using php8 the TODO has been resolved and the code can be removed See comment joomla#28694 (comment)
This pull request has been automatically rebased to 5.1-dev. |
I have tested this item ✅ successfully on 9fda474 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885. |
1 similar comment
I have tested this item ✅ successfully on 9fda474 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885. |
Hi @brianteeman I was wondering if it should be updated here as well: |
afaict its a different thing but i could be wrong. I was just following the information in the todo notice |
Thanks @brianteeman, Let's do an internal check and I'll update you |
whichever you decide any changes to those files are beyond the scope of this PR and should be handled in their own pr as they are nothing to do with the title of this PR |
Thank you @brianteeman ! |
Remove check for resource when we only support PHP 8