-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Delete 4.x update SQL scripts from last upmerge and add them to deleted files list in script.php #40372
[5.0] Delete 4.x update SQL scripts from last upmerge and add them to deleted files list in script.php #40372
Conversation
Ping @HLeithner . Question: Would it help to add the patterns |
I think it's better to keep it as it is, because we need to delete the files in this script file anyway. Maybe a notice/warning/error in the build script could make sense. |
Pull Request for Issue # .
Summary of Changes
With the last upmerge from 4.4-dev there have been again added new 4.x update SQL scripts to the 5.0-dev branch.
These files should not be merged up.
This PR here fixes that by deleting the files and adding them to the list of deleted files in script.php so they are deleted when updating from 4.x like it is done with the other 4.x update SQL scripts.
Currently there are no other changes to be done on the deleted files and folders lists in script.php in the 5.0-dev branch.
Testing Instructions
Code review.
Or if you want to make a real test, update the last 4.4 nightly build to the last 5.0 nightly build to get the actual result, and update the last 4.4 nightly build to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
There are two 4.3.0 update SQL scripts present for each kind of database after updating from the last 4.4 nightly build.
Expected result AFTER applying this Pull Request
There are no 4.x update SQL scripts present after updating from the last 4.4 nightly build.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed