Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Chore/disable polyfill php 7.0 - 8.1 #40293

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

HLeithner
Copy link
Member

We don't need the symfony polyfills for php < 8.2 since the php minimum requirement is 8.1

This PR is based on #40292

@brianteeman
Copy link
Contributor

121 changed files ?

@HLeithner
Copy link
Member Author

HLeithner commented Apr 2, 2023

121 changed files ?

as description said it's based on #40292 (the upmerge) which will be merged when the ci is ready

edit: relevant commit 593d20d

@brianteeman
Copy link
Contributor

#40287 (comment)

The changes look ok but please - one commit per issue. Nothing is really testable when you lump so many things into one pr

@HLeithner
Copy link
Member Author

I try to reduce merge conflicts, pr based on other prs is a common case, and as soon as the other pr is merged this one get cleared automatically.

@brianteeman
Copy link
Contributor

I dont see how there would have been a merge conflict - even so it makes the pr hard to review and thats why mistakes happen when there are so many changes

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators Unit/System Tests NPM Resource Changed This Pull Request can't be tested by Patchtester labels Apr 2, 2023
@HLeithner
Copy link
Member Author

I dont see how there would have been a merge conflict - even so it makes the pr hard to review and thats why mistakes happen when there are so many changes

do you understand it now? after merging the upmerge pr, this PR is clean and has only the commits related for this pr

@brianteeman
Copy link
Contributor

I understood it before - I still dont think it is good practice.

Also due to language issues I read your comment "based on" to mean the code in this pr is based on the same techniques in this other PR.

@HLeithner HLeithner merged commit 05a45ba into joomla:5.0-dev Apr 2, 2023
@HLeithner HLeithner deleted the chore/disable-polyfill-php-7-81 branch April 2, 2023 09:01
@richard67
Copy link
Member

Was just preparing my tests.

@richard67
Copy link
Member

Test was successful, PR solves the problem.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 2, 2023
@richard67 richard67 added this to the Joomla! 5.0 milestone Apr 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Apr 30, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 24, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 24, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 5, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 5, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants