-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Chore/disable polyfill php 7.0 - 8.1 #40293
[5.0] Chore/disable polyfill php 7.0 - 8.1 #40293
Conversation
121 changed files ? |
The changes look ok but please - one commit per issue. Nothing is really testable when you lump so many things into one pr |
I try to reduce merge conflicts, pr based on other prs is a common case, and as soon as the other pr is merged this one get cleared automatically. |
I dont see how there would have been a merge conflict - even so it makes the pr hard to review and thats why mistakes happen when there are so many changes |
do you understand it now? after merging the upmerge pr, this PR is clean and has only the commits related for this pr |
I understood it before - I still dont think it is good practice. Also due to language issues I read your comment "based on" to mean the code in this pr is based on the same techniques in this other PR. |
Was just preparing my tests. |
Test was successful, PR solves the problem. |
We don't need the symfony polyfills for php < 8.2 since the php minimum requirement is 8.1
This PR is based on #40292