-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Smart Search: Fixing taxonomy filter handling #39751
Conversation
Thank you!! Will test shortly. |
I have tested this item 🔴 unsuccessfully on 6647838 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39751. |
Looks good but it doesnt work. Give it a try. Search for "ricotta" in for example Pasta & Risotto recipes. |
@EJBJane without having more knowledge about your setup, it is difficult to judge your report. Yes, you don't get a result when searching for ricotta, but I also don't know what you have in the filter that is activated on your search. If you want me to debug that, please contact me on the Joomla Mattermost. |
I have to take this back, it was my fault, there was accidently an author selected for the results. This is why the search results didnt work, because there was no recipe with that author. I'm sorry! |
It thus does work for me. |
bf487cb
to
0fdf90a
Compare
I'm sorry, I accidently changed the base branch to 4.3-dev and then updated the branch with the latest changes. I actually didn't want to do that. The forced push only restores the previous state. So, we only need one more test to get this fix on the road. |
Since there wont be any more patch releases in 4.2, I'm moving this over to 4.3-dev. |
I have tested this item ✅ successfully on 6245d12 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39751. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39751. |
Does this also fix issue #40495 ? |
Yes |
Hi @Hackwar ! Is there a reason this won't go into 4.3? I ran into this issue once again on a client site so would be really nice for the bug fix to go in sooner rather than later. |
thanks |
I guess that answers that it definitely won't go in earlier, but could either of you please help me understand why? This is a bug and filters straight up don't work without the fix. |
No that's not the answer and completely independent, this fix can still be back-ported @sdwjoomla and @obuisard can do this or ask for a pr. |
The PR got a RTC label over 2 months ago and after a month of no activity from the maintainers I decided to just switch all my PRs to 5.0 in the hopes that they will at least be merged then, especially since I got messages that my PRs don't have a high chance of being merged into 4.x. So instead of wasting my time by rebasing it to 4.4 and then to 5.0, I skipped one step. It's already enough that such a fix had to be rebased from 4.2 to 4.3... |
Ok, this PR lost the RTC label and therefore got overlooked and I do apologize for it Hannes @Hackwar. It is indeed a bug that should be fixed in 4.3 in our opinion. I will backport the changes so you don't have to go through this again. |
join update to backport PR joomla#39751
Hello. I would like to ask if this will come to 4.3 at all? |
Yes in 4.3.5. See #40687. |
Thanks for the info. |
There will not be a 4.3.5. it will be 4.4.0 stable, release is Tuesday next week. |
Pull Request for Issue #39718 .
Summary of Changes
When I refactored the taxonomies to be a nested set, I overlooked this part. This means that nested taxonomies in filters don't work.
Testing Instructions
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@crystalenka can you check if this fixes your issue?