-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use filter.state for delete button in ListView #38797
Allow to use filter.state for delete button in ListView #38797
Conversation
Unit tests are consistently failing here, but I think it’s not related to this PR. The LDAP authentication tests are failing. Could be a problem on the 4.3-dev branch in general. |
P.S.: The LDAP tests have been added to 4.3-dev with PR #38593 . They one worked but now fail. |
@richard67 pr was not uptodate with 4.3-dev branch and the openldap service was missing. |
This pull request has been automatically rebased to 4.4-dev. |
I spent some time trying to test this, but I could not confirm this works. |
@tomsrocket This class is actually not used in Joomla core, so it would be for someone with code review skill. So unless you have developer experience, please ignore this PR. |
I have tested this item ✅ successfully on 628d53a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797. |
I have tested this item ✅ successfully on 628d53a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797. |
Thanks! |
Since Joomla! 4 we have a useful addToolBar function in ListView which generates the toolbar pretty well. But it's missing to accept the
filter.state
instead of the legacyfilter.published
used in some components. Since Joomla ist self also usesfilter.state
it should support it here too.Summary of Changes
Check current value of the state
filter.state
andfilter.published
.I would not expect any b/c issues because both values are used for the same usecase and at the moment you have to override
addToolbar
anyway to use thefilter.state
.Testing Instructions
Test core joomla extensions if filtering for the status "Trashed" still work.
Bonus create an extension which users
filter.state
as column field. (of course I tested it and it's working)Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
Not really because base documentation is missing.