Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use filter.state for delete button in ListView #38797

Merged

Conversation

HLeithner
Copy link
Member

Since Joomla! 4 we have a useful addToolBar function in ListView which generates the toolbar pretty well. But it's missing to accept the filter.state instead of the legacy filter.published used in some components. Since Joomla ist self also uses filter.state it should support it here too.

Summary of Changes

Check current value of the state filter.state and filter.published.
I would not expect any b/c issues because both values are used for the same usecase and at the moment you have to override addToolbar anyway to use the filter.state.

Testing Instructions

Test core joomla extensions if filtering for the status "Trashed" still work.
Bonus create an extension which users filter.state as column field. (of course I tested it and it's working)

Actual result BEFORE applying this Pull Request

  • Trash button still Trash button

Expected result AFTER applying this Pull Request

  • Trash button is now a Delete button

Documentation Changes Required

Not really because base documentation is missing.

@richard67
Copy link
Member

Unit tests are consistently failing here, but I think it’s not related to this PR. The LDAP authentication tests are failing. Could be a problem on the 4.3-dev branch in general.

@richard67
Copy link
Member

P.S.: The LDAP tests have been added to 4.3-dev with PR #38593 . They one worked but now fail.

@HLeithner
Copy link
Member Author

@richard67 pr was not uptodate with 4.3-dev branch and the openldap service was missing.

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Hackwar Hackwar added the bug label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:45
@HLeithner
Copy link
Member Author

This pull request has been automatically rebased to 4.4-dev.

@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Feb 21, 2024
@tomsrocket
Copy link

I spent some time trying to test this, but I could not confirm this works.
I am not sure I correctly understand how to test this.
Can you please add more detailed instructions how to test this?

@joomdonation
Copy link
Contributor

@tomsrocket This class is actually not used in Joomla core, so it would be for someone with code review skill. So unless you have developer experience, please ignore this PR.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 628d53a

Code review !


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797.

@Quy
Copy link
Contributor

Quy commented Mar 21, 2024

I have tested this item ✅ successfully on 628d53a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797.

@Quy Quy removed the PBF Pizza, Bugs and Fun label Mar 21, 2024
@Quy
Copy link
Contributor

Quy commented Mar 21, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 21, 2024
@laoneo laoneo merged commit 8eefbf2 into joomla:4.4-dev Mar 22, 2024
3 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 22, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 22, 2024
@laoneo laoneo added this to the Joomla! 4.4.4 milestone Mar 22, 2024
@HLeithner HLeithner deleted the feature/support_filter_state_for_trash_button branch March 27, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-4.4-dev Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants