Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if there is a valid session before messing with session ini values #15742

Closed
wants to merge 7 commits into from
Closed

Check if there is a valid session before messing with session ini values #15742

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
633c890
Closes #12153
PhilETaylor May 2, 2017
90888a0
Docs and use api
PhilETaylor May 5, 2017
a7a14ed
Implement @csthomas suggestion to move ini_sets
PhilETaylor May 5, 2017
4c8c02b
Revert @csthomas suggestion to move ini_sets
PhilETaylor May 5, 2017
da3a959
Implement @csthomas suggestion to move ini_sets to start()
PhilETaylor May 5, 2017
86033dd
Implement @mbabker suggestion to move ini_sets to JSessionHandlerJoom…
PhilETaylor May 5, 2017
b42e4af
Merge branch 'staging' into joomla-cms-15680
rdeutz May 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions libraries/joomla/session/handler/joomla.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ class JSessionHandlerJoomla extends JSessionHandlerNative
*/
public function __construct($options = array())
{
// Disable transparent sid support
ini_set('session.use_trans_sid', '0');

// Only allow the session ID to come from cookies and nothing else.
ini_set('session.use_only_cookies', '1');

// Set options
$this->setOptions($options);
$this->setCookieParams();
}
Expand Down Expand Up @@ -79,6 +72,16 @@ public function start()
}
}

// Only allow session config to be changed if no session yet started to avoid warnings
if ($this->getId() === "")
{
// Disable transparent sid support
ini_set('session.use_trans_sid', '0');

// Only allow the session ID to come from cookies and nothing else.
ini_set('session.use_only_cookies', '1');
}

return parent::start();
}

Expand Down