Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla Tag Menu Item Routing Broken #3191

Closed
MaxLynam opened this issue Feb 27, 2014 · 5 comments
Closed

Joomla Tag Menu Item Routing Broken #3191

MaxLynam opened this issue Feb 27, 2014 · 5 comments

Comments

@MaxLynam
Copy link

Steps to reproduce the issue

Create Tags.
Add some of those tags to different articles.
Create menu items which match the single tags you have created.
Test clicking on the tags when viewing the articles.
Note the articles that display when you arrive at the tag menu list.
They do not match (on most occasions) with the tag you clicked on or assigned to that menu item.

Expected result

When you click on a tag in an article, it should go to the menu item and display all atricles that match the tag set for that menu item.

Actual result

Have created tag menu items to try and get decent SEF urls, but it does not display the articles with the set (single) tag for that menu item ... it only displays the articles from the tag that was created first (in ID order)

System information (as much as possible)

Siteground
JoostrapV3 Base Template

Setting Value

PHP Built On Linux serv01.sm1.siteground.biz 2.6.32.59-sg3 #12 SMP Thu Jan 10 06:47:12 CST 2013 x86_64
Database Version 5.5.32-31.0-log
Database Collation utf8_general_ci
PHP Version 5.3.28
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 3.2.2 Stable [ Ember ] 6-February-2014 16:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36

Additional comments

.... tried with sh404sef installed to see if it would fix it, but didn't change behaviour - still wrong - had to manually re-write the URLs to get it to work


Notes from my dev:
I've found the issue. Its not a sj404sef issue. Somehow a [0] is appearing in joomla tag url which is making in-built router confused. When I follow url without it [0], it works fine.

For example,

http://www.domain.com.au/index.php?option=com_tags&view=tag&id[0]=2&Itemid=245

and

http://www.domain.com.au/index.php?option=com_tags&view=tag&id=2&Itemid=245


Well, I've fixed it by rewriting urls. I believe there's a bug in joomla- tag has a menu and sef url enabled, it cant route properly. May be they havent tried this feature. Hope it would be fixed in next joomla release.


I'm sure it probably has something to do with https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/router.php however can't work out how to submit a new issue in the Joomla github repo.

@Bakual
Copy link
Contributor

Bakual commented Feb 27, 2014

I know where the &id[0] is coming from. It's because JTags allows in the single item view multiple ids. You can in fact pass an array of ids (&id[0]=12&id[1]=23) or a string with comaseparated ids (&id=12,23).
Please note that I don't say this is good behavior, just stating why you see the URL as it is.

@MaxLynam
Copy link
Author

well ... the menu type we used is for a single tag ... so this menu type can't display multiple IDs and does not return the correct ID when clicked on from the articles tag - so routing would indeed appear broken and returns the incorrect results.

The multiple tag menu item should be able to return multiple tag listings - that is correct behaviour.

Whether single tag or multi-tag, having it operate in a way that actually returns the incorrect (tag) result is not the desired behaviour.
That's why we had to add our own redirects to get it to work.

At ALL times ..... when [0] is removed from the URL routing works as expected and the correct information is displayed.

@Bakual
Copy link
Contributor

Bakual commented Feb 28, 2014

well ... the menu type we used is for a single tag ... so this menu type can't display multiple IDs and does not return the correct ID when clicked on from the articles tag

If you used the "Tagged Items" menu item, then this is in fact not a "single tag" menu item. You can use it with a single tag, but you can add as many tags as you want. com_tags doesn't have a "single tag" view. There is only a "list of tags" and a "list of tagged items".

I'm not saying there is no bug. I'm actually fully expect there to be a lot of bugs. I just wanted to explain why there is such a strange id. Because this is important if someone wants to fix it.

At ALL times ..... when [0] is removed from the URL routing works as expected and the correct information is displayed.

It will work for a single tag, but it likely breaks as soon as multiple tags are assigned to the menuitem.

@Hackwar
Copy link
Member

Hackwar commented Nov 14, 2014

Please see if #5105 fixes some of your problems.

@jissues-bot
Copy link

Set to "closed" on behalf of @Hackwar by The JTracker Application at issues.joomla.org/joomla-cms/3191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants